Fix LT-22606: Word Cat has tan background when bundle selected#999
Merged
Conversation
Not guessing the word cat for user-approved analyses restores the pre-LT-20848 tab behavior: the Nihimbilira test data is an approved analysis with no category, so tabbing to the word cat line lands on the plain dropdown icon (ktagWordPosIcon) again. Revert the two assertions that LT-20848 had updated for the auto-filled category. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jasonleenaylor
approved these changes
Jul 8, 2026
jasonleenaylor
left a comment
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jtmaxwell3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-22606. Don't guess the word cat or word gloss if the analysis was approved by the user since it is confusing to have a mixture of approved and guessed data. This changes the fix to https://jira.sil.org/browse/LT-22577.
This change is